Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused env var: DOTNET_SKIP_FIRST_TIME_EXPERIENCE #20955

Merged
merged 1 commit into from
Sep 15, 2021
Merged

remove unused env var: DOTNET_SKIP_FIRST_TIME_EXPERIENCE #20955

merged 1 commit into from
Sep 15, 2021

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Sep 12, 2021

Resolves: #10195 (In combination with dotnet/installer#11971)

#9945 indicates this env var is no longer used.
I couldn't find usages in the SDK.

* DOTNET_SKIP_FIRST_TIME_EXPERIENCE
@bruno-garcia bruno-garcia changed the title remove unused env var * DOTNET_SKIP_FIRST_TIME_EXPERIENCE remove unused env var: DOTNET_SKIP_FIRST_TIME_EXPERIENCE Sep 12, 2021
@bruno-garcia
Copy link
Member Author

Not sure why CI failed here.
@MichaelSimons could you please give me a pointer?

@MichaelSimons
Copy link
Member

@MichaelSimons could you please give me a pointer?
I'm sorry I don't have an in-depth knowledge of the SDK tests. I work on source-build. @sfoslund can you help or refer @bruno-garcia to someone who can?

@sfoslund
Copy link
Member

We're having an outage with some of our legs today so it's probably associated with that, I expect it will work if we rerun tomorrow.

As for the change itself, @wli3 you filed this issue several years ago. Are we sure that this env var is no longer used? Is there a different one that replaced it?

@wli3
Copy link

wli3 commented Sep 15, 2021

yes DOTNET_SKIP_FIRST_TIME_EXPERIENCE is no longer respected

@marcpopMSFT marcpopMSFT merged commit 4f82527 into dotnet:main Sep 15, 2021
@bruno-garcia bruno-garcia deleted the ref/remove-unused-env-var branch September 16, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up setting DOTNET_SKIP_FIRST_TIME_EXPERIENCE in script
5 participants